Skip to content

Commit

Permalink
Suggestions (#1)
Browse files Browse the repository at this point in the history
* Update main.s

- replaced .asciz with .ascii to avoid an additional zero byte allocation
- removed unnecessary section headers not needed by linker
- added extern section for importing sol_log_

* Update main.s

removed leading .

* Update main.s

Seems we don't need the extern declaration after all!
  • Loading branch information
deanmlittle authored Sep 24, 2024
1 parent 81c111c commit 19b3947
Showing 1 changed file with 3 additions and 5 deletions.
8 changes: 3 additions & 5 deletions helloworld/asm/main.s
Original file line number Diff line number Diff line change
@@ -1,10 +1,8 @@
.text
.globl entrypoint
.globl entrypoint
entrypoint:
lddw r1, .message
mov64 r2, 12
call sol_log_
exit
.section .rodata
.message:
.asciz "Hello world!"
.rodata
message: .ascii "Hello world!"

0 comments on commit 19b3947

Please sign in to comment.