Conversation
There was a problem hiding this comment.
Just my 2 cents, it's a bit early IMO, these PHP versions are not EOL yet. I guess it's ok for Linux/MacOS that could instead use Castor binaries with PHP embeded, but not Windows ATM.
Anyway, we will also need to update the installer when we release this PR: https://github.com/jolicode/castor/blob/main/installer/bash-installer#L131-L135
|
They have not reached EOL yet. However, they are in 'security fixes only' mode. Symfony 8.x requires PHP 8.4. It was released six months ago. I think we could follow Symfony's lead, which would allow us to upgrade to Symfony 8.1 and leverage many new features (DIC, command upgrade, etc.). Finally, PHP 8.4 and PHP 8.5 are available for Windows, so we won't prevent people from upgrading. Those who cannot upgrade can stick to the current Castor version, which supports PHP 8.2. TL;DR: Not upgrading to PHP 8.4+ blocks innovation. |
pyrech
left a comment
There was a problem hiding this comment.
Not ok with this requirement upgrade but the PR looks good to me anyway, so I leave it up to you 🙃
PHP 8.2 and 8.3 are not supported anymore https://www.php.net/supported-versions.php
Note
We'll need to adapt CI rules directly in GitHub project configuration