Filtering & sorting

[loic425]

filtering.mov

[Copilot]

Pull request overview

This PR adds filtering and sorting capabilities to the Sylius admin media explorer, including recursive search behavior and UI adjustments to show full paths when browsing results across subdirectories.

Changes:

• Add Sylius Grid search filter and sortable columns (path, file size) for medias; implement sorting/filtering callbacks in the grid data provider.
• Extend OriginalStorage listing methods to accept optional in-memory filter/sort callbacks and pass them through pagination.
• Update Sylius admin Twig templates and hooks to render filters and display full paths when search is recursive; add functional tests for filtering/sorting.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
tests/Bridge/Sylius/Admin/Controller/MediaAdminControllerTest.php	Adds functional coverage for filtering and sorting behaviors in the Sylius media explorer.
src/Storage/OriginalStorage.php	Adds optional filter/sort callbacks to directory/file/media listings and pagination.
src/Bridge/Sylius/templates/admin/media/index/content/body/tabs/content/list_view/data_table/body/directories.html.twig	Displays full directory paths when recursive search is active.
src/Bridge/Sylius/templates/admin/media/index/content/body/filters.html.twig	Adds a filters include for the media index page.
src/Bridge/Sylius/templates/admin/media/grid/field/path.html.twig	Displays full media paths when recursive search is active.
src/Bridge/Sylius/src/Admin/Grid/Provider/MediaGridProvider.php	Implements filtering/sorting callbacks and recursive search behavior for the grid’s media data.
src/Bridge/Sylius/src/Admin/Grid/MediaGrid.php	Enables default sorting, adds a search filter, and makes columns sortable.
src/Bridge/Sylius/src/Admin/Controller/MediaAdminController.php	Adds sorting/filtering for directory listing and toggles recursive listing during search; removes unused Request param in show().
src/Bridge/Sylius/config/app/twig_hooks/media/index.php	Wires the new filters template into the Sylius twig hooks for the media index.

Comments suppressed due to low confidence (1)

src/Bridge/Sylius/src/Admin/Grid/Provider/MediaGridProvider.php:72

• $searchValue comes from $criteria as mixed, but it’s passed to strtolower() without casting/validation. If the query is not a string (e.g. malformed request), this will throw a TypeError. Cast to string (or guard with is_scalar) before calling strtolower() / str_contains().

        if (!empty($criteria['search']['value'] ?? null)) {
            $searchValue = $criteria['search']['value'];

            return static fn (Media $media): bool => str_contains(strtolower($media->getPath()), strtolower($searchValue));
        }

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.