Dynamic padding bottom for content. Fix robinparisi#125

joho1968 · Mar 14, 2021 · 9eadca7 · 9eadca7
1 parent 6e93c1b
commit 9eadca7
Show file tree

Hide file tree

Showing 7 changed files with 22 additions and 25 deletions.
diff --git a/dist/tingle.css b/dist/tingle.css
@@ -1,6 +1,6 @@
 /**
  * tingle.js - A simple modal plugin written in pure JavaScript
- * @version v0.15.3
+ * @version v0.16.0
  * @link https://github.com/robinparisi/tingle#readme
  * @license MIT
  */

diff --git a/dist/tingle.js b/dist/tingle.js
@@ -1,6 +1,6 @@
 /**
  * tingle.js - A simple modal plugin written in pure JavaScript
- * @version v0.15.3
+ * @version v0.16.0
  * @link https://github.com/robinparisi/tingle#readme
  * @license MIT
  */
@@ -222,8 +222,8 @@
         this.modal.appendChild(this.modalBoxFooter)
         this.modalBoxFooter.classList.add('tingle-modal-box__footer--sticky')
         _recalculateFooterPosition.call(this)
-        this.modalBoxContent.style['padding-bottom'] = this.modalBoxFooter.clientHeight + 20 + 'px'
       }
+      this.modalBoxContent.style['padding-bottom'] = this.modalBoxFooter.clientHeight + 20 + 'px'
     } else if (this.modalBoxFooter) {
       if (!this.modalBox.contains(this.modalBoxFooter)) {
         this.modal.removeChild(this.modalBoxFooter)
@@ -280,8 +280,6 @@
         this.modal.classList.remove('tingle-modal--overflow')
       }
 
-      // tODO: remove offset
-      // _offset.call(this);
       if (!this.isOverflow() && this.opts.stickyFooter) {
         this.setStickyFooter(false)
       } else if (this.isOverflow() && this.opts.stickyFooter) {

diff --git a/dist/tingle.min.js b/dist/tingle.min.js
diff --git a/doc/tingle/tingle.css b/doc/tingle/tingle.css
@@ -1,7 +1,10 @@
-/* ----------------------------------------------------------- */
-/* == tingle v0.15.2 */
-/* ----------------------------------------------------------- */
-
+/**
+ * tingle.js - A simple modal plugin written in pure JavaScript
+ * @version v0.16.0
+ * @link https://github.com/robinparisi/tingle#readme
+ * @license MIT
+ */
+
 .tingle-modal * {
   box-sizing: border-box;
 }

diff --git a/doc/tingle/tingle.js b/doc/tingle/tingle.js
@@ -1,11 +1,11 @@
-/* !
-* tingle.js
-* @author  robin_parisi
-* @version 0.15.2
-* @url
-*/
-
-/* global define,module */
+/**
+ * tingle.js - A simple modal plugin written in pure JavaScript
+ * @version v0.16.0
+ * @link https://github.com/robinparisi/tingle#readme
+ * @license MIT
+ */
+ 
+/* global define, module */
 (function (root, factory) {
   if (typeof define === 'function' && define.amd) {
     define(factory)
@@ -222,8 +222,8 @@
         this.modal.appendChild(this.modalBoxFooter)
         this.modalBoxFooter.classList.add('tingle-modal-box__footer--sticky')
         _recalculateFooterPosition.call(this)
-        this.modalBoxContent.style['padding-bottom'] = this.modalBoxFooter.clientHeight + 20 + 'px'
       }
+      this.modalBoxContent.style['padding-bottom'] = this.modalBoxFooter.clientHeight + 20 + 'px'
     } else if (this.modalBoxFooter) {
       if (!this.modalBox.contains(this.modalBoxFooter)) {
         this.modal.removeChild(this.modalBoxFooter)
@@ -280,8 +280,6 @@
         this.modal.classList.remove('tingle-modal--overflow')
       }
 
-      // tODO: remove offset
-      // _offset.call(this);
       if (!this.isOverflow() && this.opts.stickyFooter) {
         this.setStickyFooter(false)
       } else if (this.isOverflow() && this.opts.stickyFooter) {