fix: add override to css var #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's test it out! #305 |
johnnyreilly
added a commit
that referenced
this pull request
Oct 16, 2022
* feat: try fontaine * fix: add override to css var (#307) Co-authored-by: Daniel Roe <[email protected]>
johnnyreilly
added a commit
that referenced
this pull request
Oct 17, 2022
* feat: try fontaine * fix: add override to css var (#307) * chore: be explicit about version * feat: node 18 * chore: 18 * feat: 16 Co-authored-by: Daniel Roe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates fontaine to incorporate this fix, and adds the override font family to the CSS variable (as fontaine isn't yet able to connect the dots that this is being used as a font family).