Skip to content

fix(diff): ignore double-click in blank area outside diff lines #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
FourWindff wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(diff): ignore double-click in blank area outside diff lines #104

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a02c58a
fix(diff): ignore double-click in blank area outside diff lines
FourWindff May 7, 2026
d2e628c
fix(diff): handle double-click in blank area for all line types
FourWindff May 8, 2026
e6ec2f7
fix(diff): guard dblclick blank-area handler more carefully
FourWindff May 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 22 additions & 1 deletion src/components/ScrollingDiffView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -891,6 +891,23 @@ export function ScrollingDiffView(props: ScrollingDiffViewProps) {
});

onMount(() => {
function onMouseDown(e: MouseEvent) {
// For double-clicks (detail >= 2) outside a diff line, prevent the
// browser from creating its "snap to nearest text" selection at all,
// so the user doesn't see a brief blue flash on the last diff line.
// Note: this fires on the second mousedown of the sequence — the
// first mousedown of a double-click has detail === 1.
if (e.button !== 0 || e.detail < 2) return;
const target = e.target;
if (!(target instanceof Element)) return;
if (
target instanceof HTMLElement &&
(target.tagName === 'INPUT' || target.tagName === 'TEXTAREA' || target.isContentEditable)
)
return;
if (!target.closest('[data-line-type]')) e.preventDefault();
}

function onMouseUp() {
requestAnimationFrame(() => {
const sel = getDiffSelection();
Expand All @@ -911,8 +928,12 @@ export function ScrollingDiffView(props: ScrollingDiffViewProps) {
});
}

containerRef?.addEventListener('mousedown', onMouseDown);
containerRef?.addEventListener('mouseup', onMouseUp);
onCleanup(() => containerRef?.removeEventListener('mouseup', onMouseUp));
onCleanup(() => {
containerRef?.removeEventListener('mousedown', onMouseDown);
containerRef?.removeEventListener('mouseup', onMouseUp);
});
});

function handleSubmit(text: string, mode: 'review' | 'ask') {
Expand Down
Loading