Backup dont overwrite on wake #474
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+66
to
+70
| /** @brief This function writes the values in movement_state to the backup registers. | ||
| * It is used on start-up to write the defaults to each of the registers. | ||
| */ | ||
| void app_write_to_backup(void); | ||
|
|
There was a problem hiding this comment.
We should not be adding Movement specific stuff to the watch library.
|
This goes too deep to try to address this problem. We shouldn't be hacking around in the core watch library loop to fix an issue in Movement. I will dig into this and try to fix the issue without going too deep. Do we have a sense for when this was introduced? I'd much rather revert whatever change caused this than try to work around it. |
matheusmoreira
added a commit
that referenced
this pull request
Sep 10, 2024
This commit caused state restored from backup registers to be overwritten. It is thereby reverted until a better solution is found or movement is refactored. This reverts commit 524098b. Reviewed-by: Matheus Afonso Martins Moreira <[email protected]> References: #474
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue was first noticed due to #387. This PR introduced reading and writing to the backup register in order to store birthdate and location. Its implementation is correct, but it did uncover a small bug.
On startup, we call
app_setup, which writes the data inmovement_stateto the backup registers. This is good and at this point, those registers contain the defaults. However,app_setupalso gets called when we wake from sleep. This means that the values inmovement_stateoverwrite the backups. This is okay for the settings, as settings pass their pointer and get modified in every watch face, somovement_state.settingsis always up-to-date.; birthdate and location don't have that luxury.This PR moves the function that writes to the backup out of
app_setupand into the line right above whereapp_setupgets called inmain. There are 3 places whereapp_setupgets called on the watch:main,sleep, anddeep_sleep, so only including this function inmainseems appropriate.The first commit in this PR also does this, but by reading the backup register before rewriting it on wake. This is a smaller change as no new functions are added, but a worse implementation. This is due to the watch reading the backup on wake, and then just writing what it just read back to the register.
This has been tested on hardware by: