Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing bug with exclusion of data/ folders #94

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

joefutrelle
Copy link
Owner

The exclusion of data/ in the .gitignore file excludes all folders called "data", even subfolders.

@joefutrelle joefutrelle self-assigned this Feb 4, 2025
@joefutrelle
Copy link
Owner Author

See #93 for discussion.

Copy link
Collaborator

@shravani-whoi shravani-whoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree data/ is not needed in gitignore. But wonder why ifcb/data/ wasn't ignored in the previous commit with the gitignore ?

@mike-kaimika
Copy link
Collaborator

It looks like the data folder in .gitignore had only been added recently. Agreed with taking it back out

@shravani-whoi
Copy link
Collaborator

Agree data/ is not needed in gitignore. But wonder why ifcb/data/ wasn't ignored in the previous commit with the gitignore ?

NVM, ifcb/data/ was already committed.

@joefutrelle joefutrelle merged commit 0c8bfe0 into master Feb 4, 2025
8 checks passed
@joefutrelle joefutrelle deleted the fix-data-folder-exclusion-pip branch February 4, 2025 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants