Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial fileset Issue# 87 #91

Merged
merged 7 commits into from
Jan 31, 2025
Merged

Partial fileset Issue# 87 #91

merged 7 commits into from
Jan 31, 2025

Conversation

shravani-whoi
Copy link
Collaborator

No description provided.

@shravani-whoi shravani-whoi linked an issue Jan 29, 2025 that may be closed by this pull request
@shravani-whoi shravani-whoi marked this pull request as draft January 29, 2025 14:30
@@ -46,6 +49,16 @@ def test_exists(self):
assert os.path.exists(fs.adc_path)
assert os.path.exists(fs.hdr_path)
assert os.path.exists(fs.roi_path)

Copy link
Collaborator Author

@shravani-whoi shravani-whoi Jan 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joefutrelle need help in configuring this test. Need to include the partial test dataset directory here. I added the flag in the exists() method, but should I also add the flag in the FileSet constructor ?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

@joefutrelle joefutrelle marked this pull request as ready for review January 31, 2025 13:22
@joefutrelle joefutrelle merged commit c56b8ce into master Jan 31, 2025
8 checks passed
@joefutrelle joefutrelle deleted the partialFileset87 branch January 31, 2025 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide means of accessing partial filesets (with no ROI file)
2 participants