-
-
Notifications
You must be signed in to change notification settings - Fork 486
fix: for descructive action added distructive colors and styles #232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@sujal12344 is attempting to deploy a commit to the tweakcn OSS program Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughApply destructive text styling classes (e.g., Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@jnsahaj I’ve submitted a PR. Please review it and share your feedback when you get a chance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (6)
components/examples/dashboard/components/data-table.tsx(1 hunks)components/examples/dashboard/components/nav-user.tsx(1 hunks)components/examples/mail/components/mail-display.tsx(1 hunks)components/examples/tasks/components/data-table-row-actions.tsx(1 hunks)components/examples/tasks/components/user-nav.tsx(1 hunks)components/user-profile-dropdown.tsx(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Vercel Agent Review
🔇 Additional comments (5)
components/user-profile-dropdown.tsx (1)
123-128: LGTM! Destructive styling applied correctly.The destructive styling on the Logout menu item appropriately signals the action's nature while preserving existing functionality.
components/examples/tasks/components/user-nav.tsx (1)
51-54: LGTM! Consistent destructive styling.The styling matches the pattern used across other logout actions in the PR.
components/examples/tasks/components/data-table-row-actions.tsx (1)
60-63: LGTM! Destructive styling appropriately applied.The styling correctly identifies the Delete action as destructive and maintains accessibility with focus states.
components/examples/dashboard/components/nav-user.tsx (1)
97-100: LGTM! Destructive styling matches established pattern.The styling is consistent with other logout actions and appropriately signals the destructive nature of the action.
components/examples/dashboard/components/data-table.tsx (1)
282-284: LGTM! Destructive styling correctly applied.The Delete action styling is consistent with the pattern used throughout the PR and appropriately signals the destructive nature of the action.
Summary
This PR updates existing destructive actions (like Delete, Remove, Trash, Reset buttons) across the examples
to use the destructive color variant defined in the theme.
This ensures users can immediately visualize how their configured destructive color is reflected across UI components.
Changes Made
variant="destructive"prop or destructive theme token.Why
Previously, some destructive actions existed but did not visually reflect the destructive color theme.
This change makes the destructive color system consistent and clearly visible throughout the examples.
Screenshots
Related Issue
Closes #201
Summary by CodeRabbit