Improvements for code understanding #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improvements in commentaries
More comments in code. Better choice for variable name. Correction on button 9 shift when calculating the currentButtonState.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
First of all thank you for your work. It works perfect!
I downloaded your program and it worked, but I had some difficult to understand it. So I decided to do some improvements for best code understanding. I choosed new variable names, made some comments on some parts of code that were not trivial... and also a correction in the calculation of the button 9 shift.
And... I've removed some parts specific to Craig B. Sorry but I think it have no sense. I have a Pro Micro and I use the same code as you and it works. I've also been checking the ATmega32U4 datasheet trying to understand the Craig B. variant and
I have concluded that he simply needed another button layout, perhaps because the wiring in the physical implementation was more comfortable, but I think that should be more in a fork or in a variant of the general code that I think should be the one that deals of using the digital inputs of the board. It's like my concrete variant for using only 2 buttons.