feat: add missing methods #941
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheSench
commented
Aug 31, 2024
| type Queryer interface { | ||
| Query(query string, args ...interface{}) (*sql.Rows, error) | ||
| Queryx(query string, args ...interface{}) (*Rows, error) | ||
| QueryRow(query string, args ...interface{}) *sql.Row |
There was a problem hiding this comment.
Note
Adding a missing method to this interface.
We have Query/Queryx, and QueryRowx, but this method was missing.
| type QueryerContext interface { | ||
| QueryContext(ctx context.Context, query string, args ...interface{}) (*sql.Rows, error) | ||
| QueryxContext(ctx context.Context, query string, args ...interface{}) (*Rows, error) | ||
| QueryRowContext(ctx context.Context, query string, args ...interface{}) *sql.Row |
There was a problem hiding this comment.
Note
Adding a missing method to this interface.
We have QueryContext/QueryxContext, and QueryRowxContext, but this method was missing.
Comment on lines
+359
to
+361
| func (tx *Tx) NamedQueryContext(ctx context.Context, query string, arg interface{}) (*Rows, error) { | ||
| return NamedQueryContext(ctx, tx, query, arg) | ||
| } |
There was a problem hiding this comment.
Note
This method exists on DB, but was missing from Tx.
This is the only query-related method I found that is needed to allow these two types to be used interchangeably.
zhenriquegomes
approved these changes
Sep 6, 2024
|
I ran into this too! Totally agree, there should be a common interface. I ended up making one for the subset of methods that we use, but it can be easier. |
syrm
approved these changes
Oct 22, 2025
|
I need this too |
slashformotion
approved these changes
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some missing methods to flesh out interfaces and make
DBandTxhave more of a shared interface.This opens up the possibility of creating a common interface that represents either one so that functions can be written that execute queries without needing to know if they're being run within a transaction or not.
I wasn't sure how the tests were organized for this project. If there's a specific test function you'd like them added to (or a new one), let me know.
📌 Long-term (future PR), I'd like to create an interface (or a few) that represent the remaining shared query-related methods, and then one interface that represents either a
DBorTx. These are the additional methods not represented in another interface right now:Get(dest interface{}, query string, args ...interface{}) errorGetContext(ctx context.Context, dest interface{}, query string, args ...interface{}) errorMustExec(query string, args ...interface{}) sql.ResultMustExecContext(ctx context.Context, query string, args ...interface{}) sql.ResultNamedExec(query string, arg interface{}) (sql.Result, error)NamedExecContext(ctx context.Context, query string, arg interface{}) (sql.Result, error)NamedQuery(query string, arg interface{}) (*sqlx.Rows, error)NamedQueryContext(ctx context.Context, query string, arg interface{}) (*sqlx.Rows, error)PrepareNamed(query string) (*sqlx.NamedStmt, error)PrepareNamedContext(ctx context.Context, query string) (*sqlx.NamedStmt, error)Preparex(query string) (*sqlx.Stmt, error)PreparexContext(ctx context.Context, query string) (*sqlx.Stmt, error)Select(dest interface{}, query string, args ...interface{}) errorSelectContext(ctx context.Context, dest interface{}, query string, args ...interface{}) error