Skip to content

chore: remove unneeded special case #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 24, 2025
Merged

chore: remove unneeded special case #54

merged 2 commits into from
May 24, 2025

Conversation

SamMousa
Copy link
Contributor

@SamMousa SamMousa commented May 21, 2025 •
edited
Loading

While working on the PHP implementation I noticed some unneeded code paths in the typescript implementation.

@springcomp springcomp requested a review from cawalch May 21, 2025 15:13
@springcomp
Copy link
Contributor

springcomp commented May 21, 2025 •
edited
Loading

@SamMousa thank you for your contribution.

That is interesting. It seems to be path of code that will never trigger.
It seems we have the same code in both the Python and the Golang ports.

Other than that, it looks good to me.

This was referenced May 21, 2025
Open
Open
@cawalch cawalch merged commit 88e0323 into jmespath-community:main May 24, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cawalch cawalch Awaiting requested review from cawalch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SamMousa @springcomp @cawalch