Skip to content

Commit

Permalink
PR: add bump ver check (be5invis#2282)
Browse files Browse the repository at this point in the history
* Add bump-version check into the PR validation workflow

* Check condition for PR

* Setup step and job outputs for conditionals

* Fixup

* Limit fetch depth

* Fix typo

* Use a different checkout pattern

* Bump version

* Fixup conditional for the build stage

* Still allow the build stage even if the bump_version_check stage did found changes, as commits by github actions bot won't triggger actions

---------

Co-authored-by: GitHub Actions <[email protected]>
  • Loading branch information
be5invis and actions-user authored Apr 7, 2024
1 parent e866ee9 commit af8f360
Show file tree
Hide file tree
Showing 20 changed files with 224 additions and 173 deletions.
53 changes: 52 additions & 1 deletion .github/workflows/pr-build-validation.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,61 @@ name: PR Font Build Validation
on: [pull_request]

jobs:
bump_version_check:
name: Bump version check
if: github.repository == 'be5invis/Iosevka' && github.base_ref == 'dev'
runs-on: ubuntu-latest

outputs:
changed: ${{ steps.check_changes.outputs.changed }}

steps:
- name: Checkout PR
uses: actions/checkout@v4
with:
ref: ${{ github.event.pull_request.head.ref }}

- name: Use Node.js
uses: actions/setup-node@v4
with:
node-version: lts/*

- name: Bump version
run: |
npm install
npm run bump-ver
- id: check_changes
name: Check changes
run: |
git config core.autocrlf false
if git diff --quiet; then
echo "changed=0" >> "$GITHUB_OUTPUT"
else
echo "changed=1" >> "$GITHUB_OUTPUT"
fi
- name: Commit to PR
if: steps.check_changes.outputs.changed == '1'
run: |
git config --local user.email "[email protected]"
git config --local user.name "GitHub Actions"
git add --all
git commit -m "Bump version"
git push
- name: Add PR comment
uses: mshick/add-pr-comment@v2
if : steps.check_changes.outputs.changed == '1'
with:
message: |
Your pull request changes the version number.
A commit has been made to bump the version number.
build:
name: Build ${{ matrix.fontName }} font
needs: bump_version_check
if: github.repository == 'be5invis/Iosevka'

runs-on: ubuntu-latest

strategy:
Expand Down
12 changes: 6 additions & 6 deletions changes/archives/28.x/28.0.4.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
* Fix leaning marks of turned capital F/L (#2137).
* Fix overlay bar placement of Z with Hook and Z with Swash Tail (#2141).
* Fix attachment of descender parts of Cyrillic Lower Ha/X under `x` = `cursive` (#2142).
* Make the Eng part in LATIN SMALL LETTER FENG DIGRAPH always connected to the f part (#2143).
* Fix top bar shape in CYRILLIC CAPITAL LETTER DJE (#2145).
* Fix leaning marks placement for reversed k/F/P (#2150).
* Fix leaning marks of turned capital F/L (#2137).
* Fix overlay bar placement of Z with Hook and Z with Swash Tail (#2141).
* Fix attachment of descender parts of Cyrillic Lower Ha/X under `x` = `cursive` (#2142).
* Make the Eng part in LATIN SMALL LETTER FENG DIGRAPH always connected to the f part (#2143).
* Fix top bar shape in CYRILLIC CAPITAL LETTER DJE (#2145).
* Fix leaning marks placement for reversed k/F/P (#2150).
6 changes: 3 additions & 3 deletions changes/archives/5.x/5.0.6.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
* Fix incorrect serif shape for motion-serifed `m` under semi-proportional subfamilies.
* Add cursive variant for `x` and `z` (#852).
* Slab will now use more cursive variants for `k`, `x` and `z`.
* Fix incorrect serif shape for motion-serifed `m` under semi-proportional subfamilies.
* Add cursive variant for `x` and `z` (#852).
* Slab will now use more cursive variants for `k`, `x` and `z`.
* `ss15` and `ss17` are updated to use latest cursive variants (#852).
72 changes: 36 additions & 36 deletions doc/BackersArchive.md
Original file line number Diff line number Diff line change
@@ -1,36 +1,36 @@
# Backers Archive

This is an archive of former backers that sponsored Iosevka’s development during 0.x–2.x period. Iosevka will continue evolving, and thank you for your support.

## Generous Backers

- Cheng-Wei Chien
- Tianyu Ge
- (Anonymous User 4362976)
- Delton Ding
- Codi Matters
- Vasily Shmelev

## Backers

- Danny O'Brien
- Yanjia Huang
- Leon Breedt
- Alexander Payne
- Marek Kubica
- Yoshito Komatsu
- Dylan Sinnott
- robertgzr
- Pavlos Vinieratos
- Matthew Piziak
- Winnie Quinn
- Clemens
- Pascal
- Kevin Sidarous
- Beni Cherniavsky-Paskin
- Bartłomiej T. Listwon
- Will Binns-Smith
- Jeff S
- Jeri Mason
- Michael L. Ward
- Freetasy
# Backers Archive

This is an archive of former backers that sponsored Iosevka’s development during 0.x–2.x period. Iosevka will continue evolving, and thank you for your support.

## Generous Backers

- Cheng-Wei Chien
- Tianyu Ge
- (Anonymous User 4362976)
- Delton Ding
- Codi Matters
- Vasily Shmelev

## Backers

- Danny O'Brien
- Yanjia Huang
- Leon Breedt
- Alexander Payne
- Marek Kubica
- Yoshito Komatsu
- Dylan Sinnott
- robertgzr
- Pavlos Vinieratos
- Matthew Piziak
- Winnie Quinn
- Clemens
- Pascal
- Kevin Sidarous
- Beni Cherniavsky-Paskin
- Bartłomiej T. Listwon
- Will Binns-Smith
- Jeff S
- Jeri Mason
- Michael L. Ward
- Freetasy
96 changes: 48 additions & 48 deletions docker/README.md
Original file line number Diff line number Diff line change
@@ -1,48 +1,48 @@
## Make docker image
```
git clone --depth=1 https://github.com/be5invis/Iosevka.git $HOME/mkdkimg
cd $HOME/mkdkimg/docker
docker build -t=fontcc .
docker images | grep fontcc # Confirm that the docker image is generated successfully
fontcc latest c847d5e08886 About a minute ago 491MB
cd ../..
rm -rf mkdkimg/
```
Note: Make docker image need execute only one time.

## Usage
`docker run -it --rm -v $PWD:/work fontcc <BUILD_ARGS>`
Please refer to the `<BUILD_ARGS>` parameters to [Customized Build](../../dev/doc/custom-build.md#customized-build)
### Optional parameters (put them before `fontcc`):
1. `-e "VERSION_TAG=<tag>"`

`<tag>` can be the following values
- `main` git main branch
- `dev` git dev branch
- `v28.0.5` git [release version tags](../../../tags)

When this variable is omitted, the tag of the latest release will be selected

2. `-e "NPM_REG=<npm repository mirror url>"`

change `npm install` download repository to mirror site.

eg. change npm repos to huawei mirror
`docker run -it --rm -v $PWD:/work -e "NPM_REG=https://mirrors.huaweicloud.com/repository/npm" fontcc contents::Iosevka`

## Example
### Partially Build dev branch
```
mkdir -p $HOME/build_fonts
cd $HOME/build_fonts
docker run -it --rm -v $PWD:/work -e "VERSION_TAG=dev" fontcc contents::IosevkaSS06 ttf::IosevkaSS12 webfont::IosevkaSS15
ls -lR dist/
```
### Customized Build
```
cd $HOME/mycustomfonts
cat myfont1.toml myfont2.toml myfont3.toml > private-build-plans.toml
docker run -it --rm -v $PWD:/work fontcc ttf::myfont1 ttf::myfont2 contents::myfont3
ls -lR dist/
```
Note: You need prepare myfont1.toml myfont2.toml myfont3.toml youself, The [Customizer](https://be5invis.github.io/Iosevka/customizer) can help you easily generate font configuration file `.toml`.
## Make docker image
```
git clone --depth=1 https://github.com/be5invis/Iosevka.git $HOME/mkdkimg
cd $HOME/mkdkimg/docker
docker build -t=fontcc .
docker images | grep fontcc # Confirm that the docker image is generated successfully
fontcc latest c847d5e08886 About a minute ago 491MB
cd ../..
rm -rf mkdkimg/
```
Note: Make docker image need execute only one time.

## Usage
`docker run -it --rm -v $PWD:/work fontcc <BUILD_ARGS>`
Please refer to the `<BUILD_ARGS>` parameters to [Customized Build](../../dev/doc/custom-build.md#customized-build)
### Optional parameters (put them before `fontcc`):
1. `-e "VERSION_TAG=<tag>"`

`<tag>` can be the following values
- `main` git main branch
- `dev` git dev branch
- `v28.0.5` git [release version tags](../../../tags)

When this variable is omitted, the tag of the latest release will be selected

2. `-e "NPM_REG=<npm repository mirror url>"`

change `npm install` download repository to mirror site.

eg. change npm repos to huawei mirror
`docker run -it --rm -v $PWD:/work -e "NPM_REG=https://mirrors.huaweicloud.com/repository/npm" fontcc contents::Iosevka`

## Example
### Partially Build dev branch
```
mkdir -p $HOME/build_fonts
cd $HOME/build_fonts
docker run -it --rm -v $PWD:/work -e "VERSION_TAG=dev" fontcc contents::IosevkaSS06 ttf::IosevkaSS12 webfont::IosevkaSS15
ls -lR dist/
```
### Customized Build
```
cd $HOME/mycustomfonts
cat myfont1.toml myfont2.toml myfont3.toml > private-build-plans.toml
docker run -it --rm -v $PWD:/work fontcc ttf::myfont1 ttf::myfont2 contents::myfont3
ls -lR dist/
```
Note: You need prepare myfont1.toml myfont2.toml myfont3.toml youself, The [Customizer](https://be5invis.github.io/Iosevka/customizer) can help you easily generate font configuration file `.toml`.
Loading

0 comments on commit af8f360

Please sign in to comment.