Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve grouping #70

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions src/regtable.jl
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ function regtable(rr::Union{FixedEffectModel,TableRegressionModel,RegressionMode
number_regressions::Bool = true,
number_regressions_decoration::Function = i::Int64 -> "($i)",
groups = [],
hide_regressands = false,
print_fe_section = true,
print_estimator_section = true,
standardize_coef = false,
Expand Down Expand Up @@ -226,23 +227,26 @@ function regtable(rr::Union{FixedEffectModel,TableRegressionModel,RegressionMode

# Regressand block (referred to as `header` in render)
# needs to be separately rendered
regressandBlock = fill("", 1, numberOfResults+1)
for rIndex = 1:numberOfResults
# keep in mind that yname is a Symbol
regressandBlock[1,rIndex+1] = haskey(labels,string(yname(rr[rIndex]))) ? labels[string(yname(rr[rIndex]))] : _transform_labels(string(yname(rr[rIndex])))
if !hide_regressands
regressandBlock = fill("", 1, numberOfResults+1)
for rIndex = 1:numberOfResults
# keep in mind that yname is a Symbol
regressandBlock[1,rIndex+1] = haskey(labels,string(yname(rr[rIndex]))) ? labels[string(yname(rr[rIndex]))] : _transform_labels(string(yname(rr[rIndex])))
end
else
regressandBlock = fill("", 0, numberOfResults+1)
end

if length(groups) > 0
groupBlock = reshape(string.(groups), :, numberOfResults) .|> _transform_labels
regressandBlock = [fill("", size(groupBlock, 1)) groupBlock;
regressandBlock]
regressandBlock = [regressandBlock;
fill("", size(groupBlock, 1)) groupBlock]
end

# Regression numbering block (if we do it)
if number_regressions
regressionNumberBlock = fill("", 1, numberOfResults + 1)
for rIndex = 1:numberOfResults
regressionNumberBlock[1,rIndex+1] = number_regressions_decoration(rIndex)
regressionNumberBlock[1,rIndex+1] = string(number_regressions_decoration(rIndex))
end
end

Expand Down