feat: expose maxRetries in FillOptions for external retry control#162
Merged
feat: expose maxRetries in FillOptions for external retry control#162
Conversation
LiveAgentConfig already supports maxRetries (passed to generateText()), but fillForm() never threaded it through — always using DEFAULT_MAX_RETRIES = 3. Production harnesses need maxRetries: 0 to manage retries externally with full observability. Thread maxRetries from FillOptions to createLiveAgent() in both the serial fill path and the parallel fill path. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Coverage Report for packages/markform
File Coverage
|
||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
maxRetries?: numbertoFillOptionsinterface, mirroring the existing field onLiveAgentConfigmaxRetriesfromFillOptionsthrough tocreateLiveAgent()in both the serial fill path and the parallel fill pathmaxRetries: 0to disable hidden AI SDK retries and manage retries externally with full observabilityContext
LiveAgentConfigalready hasmaxRetries(line 196 of harnessTypes.ts) andLiveAgentalready uses it (passes togenerateText()), butfillForm()never passed it through — it always usedDEFAULT_MAX_RETRIES = 3. This meant all consumers of thefillForm()API had hidden AI SDK retries with no way to disable them.The existing
LiveAgentConfig.maxRetriesdoc says "Set to 0 to disable retries" so this is the intended use case.Test plan
pnpm typecheckpassespnpm buildsucceeds and built types include the new fieldMade with Cursor