Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temp and minor change for testing workflow #10

Open
wants to merge 13 commits into
base: main-test-initial-sightglass-benchmarking-action
Choose a base branch
from
Open

Temp and minor change for testing workflow #10

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
486b77d
Temp and minor change for testing workflow
jlb6740 Sep 13, 2022
a230efa
Use jq to get patch author information and fix pr fetch
jlb6740 Sep 13, 2022
99f9b1a
Update steps for wasmtime-sightglass-benchmarking repo
jlb6740 Sep 14, 2022
f00fd59
Remvoes unused pull_request_review_comment trigger
jlb6740 Sep 15, 2022
5f9cc2d
Match trigger word when contained anywhere in the pull request review…
jlb6740 Sep 15, 2022
0465041
Remove redundant repo and ref variables for wasmtime_commit
jlb6740 Sep 15, 2022
21915bb
Minor comment update
jlb6740 Sep 15, 2022
12c32f1
Remove command to install jq
jlb6740 Sep 15, 2022
abe2294
Remove printing of git config variables being used
jlb6740 Sep 15, 2022
5e415b8
Fix token for posting results
jlb6740 Sep 15, 2022
e0e7a08
Update message explaining pct_change for benchmark results
jlb6740 Sep 15, 2022
f406b60
Revert TOKEN for publsh change
jlb6740 Sep 15, 2022
ae61409
Update message explaining results
jlb6740 Sep 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 6 additions & 16 deletions .github/workflows/performance.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,11 @@ name: "Performance Testing"
# Controls when the action will run.
# This workflow runs when manually triggered using the UI or API.
on:
pull_request_review:
types: [submitted, edited]
pull_request_review_comment:
types: [created, edited]
# push:
push:

# Env variables
env:
Expand All @@ -22,20 +24,8 @@ jobs:
name: Benchmark x64 on PR comment Wasmtime repo
runs-on: ubuntu-latest
# if: (github.event_name == 'push') && (github.repository != 'bytecodealliance/wasmtime-sightglass-benchmarking')
if: |
startsWith(github.event.comment.body, '/bench_x64') &&
(github.event.issue.pull_request_review_comment) &&
(('abrown' == github.event.comment.user.login)
|| ('afonso360' == github.event.comment.user.login)
|| ('akirilov-arm' == github.event.comment.user.login)
|| ('alexcrichton' == github.event.comment.user.login)
|| ('bbouvier' == github.event.comment.user.login)
|| ('bjorn3' == github.event.comment.user.login)
|| ('cfallin' == github.event.comment.user.login)
|| ('fitzgen' == github.event.comment.user.login)
|| ('jlb6740' == github.event.comment.user.login)
|| ('sparker-arm' == github.event.comment.user.login)
|| ('uweigand' == github.event.comment.user.login))
# if: |
# startsWith(github.event.review_comment.body, '/bench_x64')
steps:
- run: echo "MESSAGE=Requested from pull request comment." >> $GITHUB_ENV
- run: echo "ACTOR=${{ github.event.comment.user.login }}" >> $GITHUB_ENV
Expand Down Expand Up @@ -67,7 +57,7 @@ jobs:
runs-on: [self-hosted, linux, x64]
if: (github.event_name == 'push') && (github.repository == 'bytecodealliance/wasmtime-sightglass-benchmarking')
steps:
# - run: echo "$GITHUB_CONTEXT"
- run: echo "$GITHUB_CONTEXT"
- run: echo "${{ github.event.head_commit.message }}"
# - name: "Build sightglass commit '${{ env.SG_COMMIT }}'"
# run: |
Expand Down