Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add ClaimTips command (untested) #70

Merged
merged 13 commits into from
Feb 4, 2025
Merged

Conversation

tomjohn1028
Copy link
Collaborator

Adds command ClaimTips using mostly the old code from https://github.com/jito-foundation/jito-solana/blob/jl/improve_mev_claim/tip-distributor/src/claim_mev_workflow.rs.

Discussion Topics

  1. Should we look refactor RpcClient to EllipsisClient in the claim process. Note it's not drop in due to lack of client support for get_multiple_accounts.
  2. Currently any TDA that doesn't have a merkle root is simply skipped. There's no log or propagated error. Is that sufficient?
  3. Prior to running the core claim_mev_tips function, should we add a check against the NCN for consensus on the Ballot for the given epoch?
  4. NOTE: I left the generated merkle collection writing without a flag as I think it's better to put behind a flag in a separate PR as we break this into the state machine.

@tomjohn1028 tomjohn1028 requested a review from ebatsell January 24, 2025 00:42
@tomjohn1028 tomjohn1028 marked this pull request as ready for review January 24, 2025 13:29
let tip_distribution_account = tip_distribution_accounts
.get(&tree.tip_distribution_account)
.unwrap();

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self: filter on merkle_root_upload_authority == Tip Router Config 8F4jGUmxF36vQ6yabnsxX6AQVXdKBhs8kGSUuRKSg8Xt

@ebatsell ebatsell merged commit 36059ab into lite-operator Feb 4, 2025
@ebatsell ebatsell deleted the add-mev-claim branch February 4, 2025 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants