AUDIT: Check Fees Fix (#55)

Was not checking the newly updated fees in `update_fee_config`
jito-foundation · Jan 17, 2025 · 5eedec8 · 5eedec8
1 parent 84de81c
commit 5eedec8
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/core/src/fees.rs b/core/src/fees.rs
@@ -330,6 +330,11 @@ impl FeeConfig {
 
         // CHECK FEES
         self.check_fees_okay(current_epoch)?;
+        self.check_fees_okay(
+            current_epoch
+                .checked_add(1)
+                .ok_or(TipRouterError::ArithmeticOverflow)?,
+        )?;
 
         Ok(())
     }

diff --git a/integration_tests/tests/tip_router/set_config_fees.rs b/integration_tests/tests/tip_router/set_config_fees.rs
@@ -79,8 +79,9 @@ mod tests {
         let ncn_root = fixture.setup_ncn().await?;
 
         const NEW_BLOCK_ENGINE_FEE: u16 = 500;
-        const NEW_BASE_FEE: u16 = 600;
-        const NEW_NCN_FEE: u16 = 700;
+        // 10_000 total, base 5000 / 8 = 625
+        const NEW_BASE_FEE: u16 = 625;
+        const NEW_NCN_FEE: u16 = 625;
 
         let new_base_fee_wallet = Pubkey::new_unique();