Keep whitespace in ProcessingInstruction's data field #212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See Sec. 2.6 in the XML 1.0 spec for details: https://www.w3.org/TR/2008/REC-xml-20081126/#sec-pi
If you have a look at the actual definition of a Processing instruction
in the XML spec, you'll see that there's no asterisk after the
Whitespace ("S") in the production rule.
[16] PI := '<?' PITarget (S (Char* - (Char* '?>' Char*)))? '?>'
According to the XML 1.0 spec, Prod. rule [3], whitespace (S) can also consist of multiple characters. I verified this in Firefox and Chromium -- both trim leading whitespace of the PIData section.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes Processing Instruction parsing (except for the XML declaration problem, which is fixed by #209), so that whitespace won't be stripped.
Details: https://www.w3.org/TR/2008/REC-xml-20081126/#sec-pi