See issue cited for master branch #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original code doesn't always work for 12:00-12:59am/pm. For example, if you use this code as is to find the number of minutes between "3:00pm-12:05am" you will get 1265 minutes for your answer because the program will think that it's counting from 3:00pm until 12:05pm the next day. The answer should be 545 minutes. Exceptions need to be made for the noon and midnight hours because these two hours uniquely spill over into the next am/pm cycle while still counting upward from the previous cycle. This is no longer an issue when 1:00(am or pm) is reached. See my edits that make exceptions for the 12:00 hours to fix this problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original code doesn't always work for 12:00-12:59am/pm. For example, if you use this code as is to find the number of minutes between "3:00pm-12:05am" you will get 1265 minutes for your answer because the program will think that it's counting from 3:00pm until 12:05pm the next day. The answer should be 545 minutes. Exceptions need to be made for the noon and midnight hours because these two hours uniquely spill over into the next am/pm cycle while still counting upward from the previous cycle. This is no longer an issue when 1:00(am or pm) is reached.
See my edits that make exceptions for the 12:00 hours to fix this problem.