Skip to content

Remove public access modifier for the TypeScript bindings #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
antonWetzel wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove public access modifier for the TypeScript bindings #319

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/ubrn_bindgen/src/bindings/gen_typescript/templates/ErrorTemplate.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ export const {{ decl_type_name }} = (() => {
*/
readonly [variantOrdinalSymbol] = {{ loop.index }};

public readonly tag = {{ type_name__Tags }}.{{ variant|variant_name }};
readonly tag = {{ type_name__Tags }}.{{ variant|variant_name }};

constructor(message: string) {
super("{{ type_name }}", "{{ variant_name }}", message);
Expand Down
6 changes: 3 additions & 3 deletions crates/ubrn_bindgen/src/bindings/gen_typescript/templates/ObjectTemplate.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,19 +40,19 @@ export class {{ impl_class_name }} extends UniffiAbstractObject implements {{ pr
{%- call private_ctor() %}

// Async primary constructor declared for this class.
{%- call ts::method_decl("public static", obj_factory, cons, 4) %}
{%- call ts::method_decl("static", obj_factory, cons, 4) %}
{%- endif %}
{%- when None %}
// No primary constructor declared for this class.
{%- call private_ctor() %}
{%- endmatch %}

{% for cons in obj.alternate_constructors() %}
{%- call ts::method_decl("public static", obj_factory, cons, 4) %}
{%- call ts::method_decl("static", obj_factory, cons, 4) %}
{% endfor %}

{% for meth in obj.methods() -%}
{%- call ts::method_decl("public", obj_factory, meth, 4) %}
{%- call ts::method_decl("", obj_factory, meth, 4) %}
{% endfor %}

{%- for tm in obj.uniffi_traits() %}
Expand Down