docs: update bindings to use uniffi 0.29 #255
Conversation
There was a problem hiding this comment.
Hey @renanmav,
Thank you so much for jumping in and fixing this.
I have left a couple of comments, mostly around the manifestPath, which is relative to the repo's project root.
If you wouldn't find fixing that, we can land this.
Thank you again.
| @@ -127,9 +127,9 @@ For now, we just want to get started; let's start with an existing Rust crate th | |||
| ```yaml | |||
| --- | |||
| rust: | |||
| repo: https://github.com/ianthetechie/uniffi-starter | |||
| branch: main | |||
| manifestPath: rust/foobar/Cargo.toml | |||
There was a problem hiding this comment.
Looking at the repo, this is the correct path.
| @@ -1,4 +1,4 @@ | |||
| rust: | |||
| repo: https://github.com/ianthetechie/uniffi-starter | |||
| branch: main | |||
| manifestPath: rust/foobar/Cargo.toml | |||
There was a problem hiding this comment.
The last line was correct to start with. :(
| @@ -1,4 +1,4 @@ | |||
| rust: | |||
| repo: https://github.com/ianthetechie/uniffi-starter | |||
| branch: main | |||
| manifestPath: rust/foobar/Cargo.toml | |||
There was a problem hiding this comment.
The first two lines work, but the last one does not :(.
|
@jhugman sorry, didn't have time to look into this. Looks like some CI steps are still failing, expected? |
No worries. Thanks for being involved.
Yes, that's unrelated to this. I'm going to merge this now. Thank you for your contribution. |
closes #249