Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed with this PR:
Long
throwsclauses previously could not break and overflowedprintWidth(default 80). The
throwsprinter now uses aconditionalGroup:currently-fitting output (full suite passes with only the overflowing
cases regenerated), otherwise
throwskept attached to theparameter list — matching the formatting sketched in
Improve formatting of method will lot of parameters and with exception #286 (comment)
Example
Input
Output
Relative issues or prs:
Fixes #286, closes #429. Supersedes #591, which targets the pre-tree-sitter
codebase and can no longer merge.
Verification
eslint,tsc, the self-format check, and a 5×idempotency run (
update-test-output.js -times 5) are clean.java-design-patternscorpus pinned bythe e2e suite (tag
1.25.0, 1508 files) under both the previous and thenew build; exactly 2 of those files change, both the intended fix
(overflowing 97/84-char
throwslines → one exception per line).Note for maintainers: the
$100/$$ bug-bounty $$labels currently sit on#591 rather than on #286/#429 — could you confirm bounty eligibility for this
fix per https://www.jhipster.tech/bug-bounties/?