Quit inner glib loop when needed #8
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This combines variations of fixes that have already been proposed. Fixes #1 Fixes jhenstridge#3
... as this also appromixates asyncio KeyboardInterrupt SIGINT behavior. Otherwise, one tends to get stuck in mainloop without convenient escape hatch.
|
Just a test report from a user (not an expert): this works well in PyQt5¹ + aiohttp app. At first I thought I will need #7 too, but it has turned out not to be the case. ¹) Qt, at least on Linux, typically uses GLib event loop under the good. |
|
The PR #9 as referenced above indeed provides a better alternative to this PR. It also has the added advantage of avoiding mess with override signal handler. So, closing this PR to defer to the other one. Note that a minor fix wrt subprocess handling is still needed, as e.g. in ReadWriteDenied/asyncio-glib@0780e6e or also in alternative PR #10. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... such as when a python asyncio callback is scheduled (this is a variation on other pull requests).
Also, optionally allow GLib's (override) handling of SIGINT (rather than viewing as interference), so one escape the loop that way as well.