Batch by total request message size. #410
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petermyers
changed the title
petermyers
changed the title
jgilbert01
reviewed
Jun 9, 2025
|
|
||
| export const sendToSqs = ({ // eslint-disable-line import/prefer-default-export | ||
| id: pipelineId, | ||
| debug = d('sqs'), | ||
| queueUrl = process.env.QUEUE_URL, | ||
| messageField = 'message', | ||
| batchSize = Number(process.env.SQS_BATCH_SIZE) || Number(process.env.BATCH_SIZE) || 10, | ||
| maxPublishRequestSize = Number(process.env.PUBLISH_MAX_REQ_SIZE) || Number(process.env.MAX_REQ_SIZE) || 256 * 1024, |
There was a problem hiding this comment.
- the batchWithSize util has event specific logic, like claim checks
- this sqs sink is used for non-event type messaging in egress gateways
- it would be nice to iterate on the util to make it more generic
- but maybe in this case a custom sqs sink is warranted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the aws docs for SendMessageBatch:
The maximum allowed individual message size and the maximum total payload size (the sum of the individual lengths of all of the batched messages) are both 256 KiB (262,144 bytes).batchWithSizealready does most of the work andfromSqsEventalready redeems the claimchecks anyway.