allow overriding the cdc event field #307
Conversation
codyjmoody
force-pushed
the
override-cdc-event-field
branch
2 times, most recently
from
2a24ed8 to
051a0b0
Compare
| ? uow | ||
| : ({ | ||
| ...uow, | ||
| event: { |
There was a problem hiding this comment.
i would think we just need to override this field with [rule.eventField || 'event']
There was a problem hiding this comment.
in my mind the purpose of overriding the event field would be to avoid spreading the uow.event in the toEvent function like in job. I think the commit I just added has this simplification but still allows avoiding spreading uow.event
There was a problem hiding this comment.
revisiting this after an update - the purpose of this MR is to be able to override the cdc event field so that the toEvent can short circuit and not publish. currently, if you return null or undefined in toEvent, cdc will still publish. we can't add a field like shortCircuit: true to the rule because it won't be backwards compatible
codyjmoody
force-pushed
the
override-cdc-event-field
branch
2 times, most recently
from
83a862b to
c48c6c4
Compare
codyjmoody
force-pushed
the
override-cdc-event-field
branch
from
c48c6c4 to
aa5a6b8
Compare
No description provided.