scraper: skip price info request for invalid SKUs #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some SKUs seem to have been removed from the CT database. Unfortunately,
they are still listed by the API endpoints we use to list products and
SKUs.
When we attempt a PriceAvailability request for a batch of SKUs that
contains an invalid SKU, the service replies with the following kind of
error:
{
"statusCode": 400,
"errors": [
"An error on the server occurred"
],
"isCdsError": true,
"error": "Bad Request",
"errCode": "0",
"xRequestId": null,
"requestId": "3706a044-a8d1-4691-97cf-bdb78eae08c7",
"correlationId": "f5ebd64d-8c62-4c6a-bb18-1989391cfa1a"
}
I have not found anything in the SKU listing response that allows us to
determine which SKUs are no longer valid.
For the moment, this provides a work-around by falling back to
individually querying for the price of each SKU when a batch fails with
the '400' status code.
Signed-off-by: Jérémie Galarneau <[email protected]>
jgalar
force-pushed
the
skip.dead.skus
branch
from
e91a891 to
78214e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some SKUs seem to have been removed from the CT database. Unfortunately, they are still listed by the API endpoints we use to list products and SKUs.
When we attempt a
PriceAvailabilityrequest for a batch of SKUs that contains an invalid SKU, the service replies with the following type of error:{ "statusCode": 400, "errors": [ "An error on the server occurred" ], "isCdsError": true, "error": "Bad Request", "errCode": "0", "xRequestId": null, "requestId": "3706a044-a8d1-4691-97cf-bdb78eae08c7", "correlationId": "f5ebd64d-8c62-4c6a-bb18-1989391cfa1a" }I have not found anything in the SKU listing response that allows us to determine which SKUs are no longer valid.
For the moment, this provides a work-around by falling back to individually querying for the price of each SKU when a batch fails with the '400' status code.