Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PyBytes
post PR (pyo3-bytes slicing developmentseed/obstore#249)AI WORD SALAD
This pull request includes several enhancements and refactorings across multiple files in the
ryo3
project. The changes include the addition of new features, code cleanups, and improvements to existing functionalities. Below are the most important changes grouped by theme:New Features:
PyFileType
andPyMetadata
classes tocrates/ryo3-std/src/fs.rs
to expose file metadata and file type information to Python. [1] [2]is_match
method inPyGlobster
to check if a path matches the glob pattern. [1] [2]Code Improvements:
slice
method incrates/ryo3-bytes/src/bytes.rs
to improve readability and maintainability.isascii
method incrates/ryo3-bytes/src/bytes.rs
by removing commented-out code and using a more straightforward implementation.Code Cleanup:
PyBytesWrapper
struct and its associated functionbytes_sum_bytes_wrapper
fromcrates/ryo3-bytes/src/bytes_dev.rs
. [1] [2]#[allow(...)]
/#![allow(...)]
to#[expect(...)]
/#![expect(...)]
in theCHANGELOG.md
file.Dependency Updates:
ryo3-std
as a workspace dependency incrates/ryo3-walkdir/Cargo.toml
.Structural Changes:
WalkDirEntry
implementation to a separate modulewalkdir_entry
and refactoredPyWalkdirGen
to use a boxed iterator for better flexibility and performance. [1] [2]