Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fs structs #202

Merged
merged 3 commits into from
Feb 18, 2025
Merged

Fs structs #202

merged 3 commits into from
Feb 18, 2025

Conversation

jessekrubin
Copy link
Owner


AI WORD SALAD

This pull request includes several enhancements and refactorings across multiple files in the ryo3 project. The changes include the addition of new features, code cleanups, and improvements to existing functionalities. Below are the most important changes grouped by theme:

New Features:

  • Added PyFileType and PyMetadata classes to crates/ryo3-std/src/fs.rs to expose file metadata and file type information to Python. [1] [2]
  • Introduced a new is_match method in PyGlobster to check if a path matches the glob pattern. [1] [2]

Code Improvements:

  • Refactored the slice method in crates/ryo3-bytes/src/bytes.rs to improve readability and maintainability.
  • Simplified the isascii method in crates/ryo3-bytes/src/bytes.rs by removing commented-out code and using a more straightforward implementation.

Code Cleanup:

  • Removed the PyBytesWrapper struct and its associated function bytes_sum_bytes_wrapper from crates/ryo3-bytes/src/bytes_dev.rs. [1] [2]
  • Switched all lints from #[allow(...)]/#![allow(...)] to #[expect(...)]/#![expect(...)] in the CHANGELOG.md file.

Dependency Updates:

  • Added ryo3-std as a workspace dependency in crates/ryo3-walkdir/Cargo.toml.

Structural Changes:

  • Moved the WalkDirEntry implementation to a separate module walkdir_entry and refactored PyWalkdirGen to use a boxed iterator for better flexibility and performance. [1] [2]

Copy link

Deploying ry with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0a70548
Status:⚡️  Build in progress...

View logs

@jessekrubin jessekrubin merged commit db86100 into main Feb 18, 2025
20 of 21 checks passed
@jessekrubin jessekrubin deleted the fs-structs branch February 18, 2025 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant