Repository navigation
Keep mailmapped commits visible when filtering by author - #6166
Open
noahfraiture wants to merge 3 commits into
Open
noahfraiture wants to merge 3 commits into
noahfraiture wants to merge 3 commits into
Conversation
Selecting a commit with a mailmapped identity currently filters that same commit out of the list. Keep the expected result beside the observed one so the fix can switch the assertion. Co-authored-by: GPT-6 <codex@openai.com>
Both log paths need the same treatment of author identities. Put their shared argument construction in one place before changing how mailmap affects matching. Co-authored-by: GPT-6 <codex@openai.com>
The commit list already shows canonical names, but it paired them with raw email addresses. Git also lets log.mailmap=false disable canonical author matching. Use the mapped email and ask filtered log commands to match against the same canonical identity. Co-authored-by: GPT-6 <codex@openai.com>
noahfraiture
marked this pull request as ready for review
October 30, 2026 17:22
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
When a commit author is corrected by
.mailmap, selecting that commit and filtering by its author can leave the commits list empty, excluding the selected commit itself.To reproduce:
Legacy Name <old@example.com>.Canonical Name <new@example.com> Legacy Name <old@example.com>to.mailmap.s, and choose its author.Fix
Read the mailmapped author email with Git's
%aEformat, and use mailmap for author filtering in both normal and reflog commit queries. This keeps the filter aligned with the author identity shown by lazygit, including whenlog.mailmap=false.Validation
env -u NO_COLOR just checkpassed (unit tests, integration tests, lint, and generated-file check).just buildpassed.