feat: show actual file count in files panel footer#5467
Open
PeterTimCousins wants to merge 1 commit intojesseduffield:masterfrom
Open
feat: show actual file count in files panel footer#5467PeterTimCousins wants to merge 1 commit intojesseduffield:masterfrom
PeterTimCousins wants to merge 1 commit intojesseduffield:masterfrom
Conversation
In tree mode, the files panel footer shows "X of Y" where Y includes directory nodes. This can be confusing since it doesn't match the actual number of changed files (as shown by git status). Add a file count suffix to the footer so it reads e.g. "1 of 39 | 23 changes", making the true number of changed files visible at a glance while keeping the tree navigation counter intact. This is implemented via a generic footerExtra callback on ListContextTrait, so other contexts can add footer info in the future without modifying the shared setFooter logic.
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
TIP This summary will be updated as you push new changes. Give us feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In tree mode, the files panel footer shows
X of Ywhere Y includes directory nodes in the tree. This doesn't match the actual number of changed files (as reported bygit status), which can be confusing.This adds a file count suffix to the footer so it reads e.g.
1 of 39 | 23 changes, making the true number of changed files visible at a glance while keeping the tree navigation counter intact.Before:
1 of 39After:
1 of 39 | 23 changesWhen not in tree mode, both numbers match so the suffix is still shown but isn't surprising.
Implementation
footerExtracallback field toListContextTrait— other contexts can use this in the future without modifying shared footer logicWorkingTreeContextsets the callback to return the count fromGetAllFiles()(actual files, no directories)1 changevs23 changes)Files changed
pkg/gui/context/list_context_trait.go—footerExtrafield +setFooter()appends extra infopkg/gui/context/working_tree_context.go— setsfooterExtrato show file count