Add confirmation dialogs for destructive workspace reset actions#5464
Open
TK88101 wants to merge 1 commit intojesseduffield:masterfrom
Open
Add confirmation dialogs for destructive workspace reset actions#5464TK88101 wants to merge 1 commit intojesseduffield:masterfrom
TK88101 wants to merge 1 commit intojesseduffield:masterfrom
Conversation
The workspace reset menu had several destructive actions that executed immediately without confirmation, risking accidental data loss. Add confirmation prompts before: discard unstaged changes (git checkout -- .), discard untracked files (git clean -fd), and discard staged changes (stash and drop). Update the existing integration test to expect the new confirmation dialog. Closes jesseduffield#874
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 4 |
TIP This summary will be updated as you push new changes. Give us feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
git checkout -- .)git clean -fd)discard_staged_changesintegration test to handle the new confirmation dialogCloses #874
Test plan
Shift+D), verify confirmation dialogs appear foru,c,SoptionsEscon confirmation cancels the actionEnteron confirmation executes the actiongo test pkg/integration/clients/*.go)go test ./pkg/gui/... ./pkg/i18n/...)