-
Notifications
You must be signed in to change notification settings - Fork 87
Adds ability to pass in config object with custom fs #69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Also allows passing options to add debugging in order to trace the internal flow.
All test pass. Fully compatible with previous API :) |
Hey @kristianmandrup. Thanks for this pull request. A few comments: Unfortunately there are quite a few changes here which would make recursive-readdir break on older versions of node - let, fat arrows, async/await, etc. I don't want to drop support for those versions. Can you help me understand the problem you're trying to solve by allowing You mention an in-memory fs as well. What problem would using that solve? Adding more debug logging is a good idea, but it seems pretty disconnected from the core purpose of this pull request. I'd prefer to make each pull request do one thing instead of combining multiple unrelated changes. Ditto with adding a package-lock.json - this is unrelated to the purpose of this PR. |
Hi @jergason I had trouble mocking |
Useful for use with in-memory fs or when mocking the fs