Add somes metrics and improvements to the plugin

[mat1e]

Hi,

Firstly, I want to thank you for this plugin. We are using it to build Boards with Grafana and influxDB and it is working well.
We added somes improvements and datas and we want share it, it can be nice to integrate :

• instance : Jenkins instance (we have 10 Jenkins running)
• Button "Test connection" in global configuration
• Usage of Credentials for Sonarqube
• build_user : the User who launch the build
• build_cause : Trigger type (className like UserCause or SCMTriggerCause)
• build_causer : cause description like displayed on the build.
• agent_point with agent_name and agent_label
• project_path : path to the job
• git_point with git_repository, git_revision and git_reference

I'm waiting your return if you have any questions and suggestions.
We are doing a second version with more improvements.

[asimell]

Hi,

Thanks for the PR! I already left a few comments to the pom.xml, but I will come back to this more thoroughly later.

Meanwhile, as Spotbugs also found out, there's quite a few bugs that need to be addressed before this can be merged. Also, since this is quite a big PR, going through all the changes is a lot of work and checking everything will take a lot of time. I suggest you split this PR into several smaller parts, so that each feature is its own PR:

• Add Test Connection button
• Add Git Point (could this be combined with changelog_data, so that there's only one measurement for all SCM related data?)
• Credentials for SonarQube support
• New metrics for existing measurements.
• Pure maintenance, which don't affect any functionality (such as pom.xml reordering, import organization, etc.)

This way it's easier to test and debug only one feature at a time and ensure it works as intended.

When adding new metrics, please also update the available metrics documentation, thank you! The next release version will be 3.4, so you can use that when filling the introduced in sections of the tables.

[mat1e]

@HabibMAALEM what do you think about combine git_point with changelog_data ?

[HabibMAALEM]

Hi @mat1e, the slight difference between them is that changelog_data collects metrics about changes provided by the SCM (SVN, Git ...) it's a core fonctionnality of Jenkins initially was used with SVN and now every plugin that implement it can print changes in the Change page https://ci.jenkins.io/job/{job_name}/{build_number}/changes

In other hand git_data metric collect every Git checkout in the build (repository, reference, revision). So for a given build we have only one changeset but we can have multiple Git checkout (application repository, tests repository, deployment repository ...)

[mat1e]

Hi @mat1e, the slight difference between them is that changelog_data collects metrics about changes provided by the SCM (SVN, Git ...) it's a core fonctionnality of Jenkins initially was used with SVN and now every plugin that implement it can print changes in the Change page https://ci.jenkins.io/job/{job_name}/{build_number}/changes

In other hand git_data metric collect every Git checkout in the build (repository, reference, revision). So for a given build we have only one changeset but we can have multiple Git checkout (application repository, tests repository, deployment repository ...)

Thank you @HabibMAALEM for this clear explanation. So @asimell, I will keep git_point metrics and push a Pull Request for it if you agree.

[mat1e]

@asimell, I reworked the changes to fit with the actual revision. I have to update the metrics documentation.
And that's it for now, I will submit features from improve_plugin_V2 when tests will be finished on our side.

[mat1e]

PR splitted --> #151 #152 #153 #154 #155