-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GitHub branch and pull request info to the 'Details' widget #826
base: master
Are you sure you want to change the base?
Conversation
import hudson.ExtensionList; | ||
import jenkins.model.details.DetailGroup; | ||
|
||
// TODO - Should be moved to parent plugin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be moved to scm-api I think?
SCMRevisionAction scmRevisionAction = getObject().getAction(SCMRevisionAction.class); | ||
SCMRevision revision = scmRevisionAction.getRevision(); | ||
|
||
if (revision instanceof AbstractGitSCMSource.SCMRevisionImpl abstractRevision) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
potentially belongs in the Git plugin? and then this plugin only handles the pull request one?
Although not sure if you could figure out the link from there, maybe you can though?
jenkinsci/jenkins#10147
TODO
Description
A brief summary describing the changes in this pull request. See
JENKINS-XXXXX for further information.
Submitter checklist
Reviewer checklist
Documentation changes
Users/aliases to notify