Skip to content

[JENKINS-68321] Call Connector.configureLocalRateLimitChecker more consistently #654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

[JENKINS-68321] Call Connector.configureLocalRateLimitChecker more consistently #654

wants to merge 5 commits into from

Conversation

jglick
Copy link
Member

@jglick jglick commented Jan 12, 2023

Alternative to #653, in case the problem is the lack of a correct localRateLimitChecker. The thread dump from Jira shows

github-branch-source-plugin/src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigator.java

Lines 926 to 927 in addca9c

// optimize for the single source case
visitSource(includes.iterator().next(), observer);
being called and this does not seem to set the checker.

@samrocketman samrocketman mentioned this pull request Sep 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jglick