Skip to content

[JENKINS-74133] Extract inline JavaScript from AutomateTestAction/summary.jelly #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[JENKINS-74133] Extract inline JavaScript from AutomateTestAction/summary.jelly #85

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions src/main/resources/com/browserstack/automate/ci/jenkins/AutomateTestAction/resource.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
document.addEventListener("DOMContentLoaded", () => {
const { sessionId } = document.querySelector(".browserstack-analytics-data-holder").dataset;

var startTime = (new Date).valueOf();
function onLoadIFrame() {
testAction.iframeLoadTime((new Date).valueOf() - startTime);
}

var iframeElem = document.getElementById('browserstack-iframe-' + sessionId);
if (iframeElem.addEventListener) {
iframeElem.addEventListener('load', onLoadIFrame, true);
} else if (iframeElem.attachEvent) {
iframeElem.attachEvent('onload', onLoadIFrame);
}
});
20 changes: 3 additions & 17 deletions src/main/resources/com/browserstack/automate/ci/jenkins/AutomateTestAction/summary.jelly
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,23 +35,9 @@

<iframe id="browserstack-iframe-${session.id}" src="${session.publicUrl}" class="browserstack-session-frame" allowfullscreen="true" webkitallowfullscreen="true" mozallowfullscreen="true" />

<script type="text/javascript">
var testAction = <st:bind value="${it}"/>
var sessionId = <st:bind value="${session.id}" />
//<![CDATA[
var startTime = (new Date).valueOf();
function onLoadIFrame() {
testAction.iframeLoadTime((new Date).valueOf() - startTime);
}

var iframeElem = document.getElementById('browserstack-iframe-' + sessionId);
if (iframeElem.addEventListener) {
iframeElem.addEventListener('load', onLoadIFrame, true);
} else if (iframeElem.attachEvent) {
iframeElem.attachEvent('onload', onLoadIFrame);
}
//]]>
</script>
<st:bind value="${it}" var="testAction"/>
<span class="browserstack-analytics-data-holder" data-session-id="${session.id}"/>
<st:adjunct includes="com.browserstack.automate.ci.jenkins.AutomateTestAction.resource"/>

<style type="text/css">
.browserstack-session-frame {
Expand Down
Loading