fix: valid app name for docker registry

Signed-off-by: ankitm123 <[email protected]>

pkg/cmd/variables/test_data/tests/nested/expected.sh

@@ -0,0 +1,20 @@
+
+# generated by: jx gitops variables
+export APP_NAME='mygroup-myrepo'
+export BRANCH_NAME='PR-23'
+export BUILD_NUMBER='5'
+export DOCKERFILE_PATH='Dockerfile'
+export DOCKER_REGISTRY='my-registry.com'
+export DOCKER_REGISTRY_ORG='myowner'
+export DOMAIN='mydomain.com'
+export GIT_BRANCH='mybranch'
+export JENKINS_X_URL='https://dashboard-mydomain.com/MyOwner/mygroup/myrepo/PR-23/5'
+export JX_CHART_REPOSITORY='http://bucketrepo/bucketrepo/charts/'
+export KANIKO_FLAGS='cheese'
+export MINK_AS='tekton-bot'
+export MINK_IMAGE='my-registry.com/myowner/mygroup/myrepo:1.2.3'
+export PIPELINE_KIND='pullrequest'
+export PUSH_CONTAINER_REGISTRY='localhost:5000'
+export REPO_NAME='mygroup/myrepo'
+export REPO_OWNER='MyOwner'
+export VERSION='1.2.3'

pkg/cmd/variables/variables.go

@@ -197,7 +197,7 @@ func (o *Options) Validate() error {
 		{
 			Name: "APP_NAME",
 			Function: func() (string, error) {
-				return o.Options.Repository, nil
+				return naming.ToValidName(o.Options.Repository), nil
 			},
 		},
 		{

pkg/cmd/variables/variables_test.go

@@ -88,7 +88,7 @@ func TestCmdVariables(t *testing.T) {
 		o.GitBranch = "mybranch"
 		o.DashboardURL = "https://dashboard-mydomain.com"
 
-		if name == "empty" {
+		if name == "empty" || name == "nested" {
 			o.Requirements = &requirements.Spec
 		}
 
@@ -107,6 +107,9 @@ func TestCmdVariables(t *testing.T) {
 		)
 		o.Options.Owner = "MyOwner"
 		o.Options.Repository = "myrepo"
+		if name == "nested" {
+			o.Options.Repository = "mygroup/myrepo"
+		}
 		o.Options.Branch = "PR-23"
 		o.Options.SourceURL = "https://github.com/" + o.Options.Owner + "/" + o.Options.Repository
 		o.Options.ScmClient = scmFake