This repository was archived by the owner on May 31, 2025. It is now read-only.
Support install target and build without tests #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isaachier
reviewed
Nov 9, 2017
| @@ -57,6 +57,7 @@ option(enable-lazy-lock "Enable lazy locking (only lock when multi-threaded" OFF | |||
| option(force_lazy_lock "Forcing lazy-lock to avoid allocator/threading bootstrap issues" OFF) | |||
| # install_prefix - installation directory prefix | |||
| # with-xslroot=<path> XSL stylesheet root path | |||
| option(build-tests "Build tests" OFF) | |||
There was a problem hiding this comment.
Just use CMake/CTest variable BUILD_TESTING instead of a new option.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes without whitespaces https://github.com/jemalloc/jemalloc-cmake/pull/3/files?w=1