Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add existing localizations to Xcode project #1417

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

samglt
Copy link
Contributor

@samglt samglt commented Jan 30, 2025

Fixing: #1327

About 30 localizations that have been merged from Weblate were not added into the Xcode project so they weren't actually usable

For reference the way I added them from the UI was:
Right click the Translations folder > Add Files to "Swiftfin" > Select the .lproj folders > Add > Reference files in place & Create groups & check both targets > Finish

@JPKribs JPKribs added the enhancement New feature or request label Jan 30, 2025
Copy link
Member

@LePips LePips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much. Interesting that Weblate doesn't automatically add these to the project, which I thought that it did. I don't know how this could be automated right now, but it isn't a bad idea.

Just brainstorming: I have been following Tuist for a while but haven't actually used it. Maybe it can help us in this situation.

@LePips LePips merged commit e21ca65 into jellyfin:main Feb 7, 2025
4 checks passed
@JPKribs JPKribs linked an issue Mar 6, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Languages missing from app settings
3 participants