Initialize a new advanced metadata field for tags #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ashmaroli Is this still a WIP or will this get discarded? |
|
@gsantner its still in WIP.. waiting for the API to mature enough to easily facilitate |
- disable converting associated value-field to 'list' type - filter suggestions based on input value - misc. css adjustments
mertkahyaoglu
approved these changes
Mar 8, 2020
| @@ -21,6 +21,7 @@ export class MetaObject extends Component { | |||
| let type = 'simple'; | |||
| if (_.isObject(value)) type = 'object'; | |||
| if (_.isArray(value)) type = 'array'; | |||
| if (_.isArray(value) && key === 'tags') type = 'simple'; | |||
There was a problem hiding this comment.
Could you extract these conditions into a method which returns type given value?
There was a problem hiding this comment.
Good idea. Will handle this in a separate PR..
|
This feature lacks one thing currently: there's no way to select existing tag.. |
|
That could be done in another pr maybe another release. This is quite enough IMO. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by #380
commakey ,xautocompletesuggestionssite.tags