Support frontmatter defaults in the front end #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashmaroli
reviewed
May 2, 2017
| @@ -113,6 +114,8 @@ export class DocumentEdit extends Component { | |||
| } = currentDocument; | |||
| const [directory, ...rest] = params.splat; | |||
|
|
|||
| const metafields = injectDefaultFields(config, directory, collection, front_matter); | |||
There was a problem hiding this comment.
config is since recently,
{"content": {"foo": "bar"}, "raw_content": "foo: bar\n"}
So either this line and all instances of config passed to injectDefaultFields should be changed to config.content or change injectDefaultFields function to extract defaults from config.content
mertkahyaoglu
changed the title
|
@mertkahyaoglu found a minor bug with this via |
|
Thanks @ashmaroli 👍 . Recently I came across with this library from Facebook that will fix this kind of console errors very easily. I will try to integrate this when I get some time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ability to view frontmatter defaults in the front end. Frontmatter defaults are inserted into metadata section of pages/documents' views to let users visually see all of the fields they have.
To achieve this, we read frontmatter defaults from the config file and inject them into metadata of pages and documents.
Fixes #165