Support custom config files from CLI #322
Conversation
There was a problem hiding this comment.
What's the desired user experience here? To only be able to modify the first configuration file? Would it make more sense to abstract configuration into configuration files? How often do we think users will want to modify secondary configuration files? IIRC having a singular configuration file was a purposeful design decision to keep things slim (but that doesn't mean it can't be changed now if there's a strong reason).
lib/jekyll/commands/serve.rb
Outdated
| @@ -2,6 +2,21 @@ module Jekyll | |||
| module Commands | |||
| class Serve < Command | |||
| class << self | |||
| def process(opts) | |||
There was a problem hiding this comment.
Rather than monkey patching another method, can we pass the options hash to our existing monkeypatch?
There was a problem hiding this comment.
I couldn't find another way to bypass this deletion
lib/jekyll/commands/serve.rb
Outdated
|
|
||
| def custom_configs | ||
| return nil unless @overrides | ||
| @overrides |
There was a problem hiding this comment.
Could this be simplified to an attr_accessor?
There was a problem hiding this comment.
I was under the impression that when we define an attr_accessor, its called again via #initialize method
Primarily, to be in sync with existing Jekyll functionality and be able to edit the site built/served with the specified configuration file. --
When the user builds/serves via a list of config files, its understood and documented that the effective config hash will be a merged singularity. But instead of displaying contents of all the config files in the list, we shall simply allow writing to the first of specified config files. --
Jekyll's build options allow one to specify custom config files. JekyllAdmin's UX gets hampered when we turn a blind-eye to an existing long-standing core functionality. --
For initial release, that was a wise decision. But its time to expand the scope.. 😁 |
ashmaroli
force-pushed
the
custom-config-hash
branch
from
b4b3369 to
918e9b5
Compare
|
I believe this is ready a final review.. |
|
Update: This will not work on |
ashmaroli
force-pushed
the
custom-config-hash
branch
from
6c1a1f8 to
bede786
Compare
|
@mertkahyaoglu @benbalter Guys, I believe this is once again ready for a scrutiny.. |
Fixes #321
When you provide an array of config files via the
--configswitch, we'll read and write to the first of such files.