Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loss of scrolling in all UI after saving in fullscreen #433

Closed
JohannesMP opened this issue Nov 22, 2017 · 1 comment
Closed

Loss of scrolling in all UI after saving in fullscreen #433

JohannesMP opened this issue Nov 22, 2017 · 1 comment
Labels

Comments

@JohannesMP
Copy link
Contributor

JohannesMP commented Nov 22, 2017

Description:

When using Jekyll admin, I've noticed several occasions where for some reason scrolling is disabled in the main editor view.

One case where this happens that I've been able to reproduce somewhat consistently is when saving while in fullscreen mode:

Often (but for some reason not always) saving in fullscreen will kick you back to the default editor view. While this is annoying enough by itself (see my old issue report here: #305), it also results in the scroll bar disappearing and the view no longer having the ability to scroll, making some elements of the UI, such as the metadata editor, completely inaccessible.

Tell us a bit about yourself:

  • Version of JekyllAdmin I'm using: 0.7.0
  • Version of Jekyll I'm using: 3.6.2
  • Operating System: Windows 10
  • Browser: Chrome Version 62.0.3202.94 (Official Build) (64-bit)

Steps to reproduce:

  1. Create a new post
  2. Enter a title
  3. Enter fullscreen mode (either 2 pane or single pane)
  4. Enter anything in the body field - basically just so the document is marked as modified and saving is possible.
  5. Save, either by hitting the save button or CTRL+S

You should be kicked back to the main editor. More importantly, you will no longer be able to scroll the page at all. This will persist even if you navigate to a different post or config screen. The only way to re-enable the ability to scroll in the main view is to refresh the page.

You can also reproduce this with an existing document, although there saving will not always kick you out of the editor. If it does not, exiting fullscreen, enter it again, make another change, and try saving again.

In any case, getting kicked out of fullscreen seems to be directly related to scrolling breaking.

I expected the following:

I expect to be able to scroll on a page that contains more data than can fit into the view at once.

Other details:

Screen capture:
jekylladminfullscreen2-0

@JohannesMP JohannesMP changed the title Loss of scroll bar in editor after full screen Loss of scrolling in all UI after saving in fullscreen Nov 22, 2017
@jekyllbot
Copy link

This issue has been automatically marked as stale because it has not been commented on for at least two months.

The resources of the Jekyll team are limited, and so we are asking for your help.

If this is a bug and you can still reproduce this error on the master branch, please reply with all of the information you have about it in order to keep the issue open.

If this is a feature request, please consider whether it can be accomplished in another way. If it cannot, please elaborate on why it is core to this project and why you feel more than 80% of users would find this beneficial.

This issue will automatically be closed in two months if no further activity occurs. Thank you for all your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants