Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post editor exiting fullscreen on save #305

Closed
JohannesMP opened this issue Feb 21, 2017 · 6 comments
Closed

Post editor exiting fullscreen on save #305

JohannesMP opened this issue Feb 21, 2017 · 6 comments

Comments

@JohannesMP
Copy link
Contributor

JohannesMP commented Feb 21, 2017

Description:

When saving a post while in fullscreen mode (either single or double column view)

  • Half the time I get a Could not update the doc error
  • Half the time there is no error, and the page resets to its non-fullscreen state. (the focus of this post)

Oddly enough, when I get the error the document does actually seem to have saved, as I can tell by reloading the 'live' version of the post.

So ironically, I actually prefer getting the error because then I don't get kicked out of fullscreen view.

Tell us a bit about yourself:

  • ruby v2.3.3p222
  • jekyll-admin v0.3.0
  • jekyll v3.3.1
  • Windows 10
  • Chrome v56.0.2924.87 (64-bit)

Steps to reproduce:

  • Create a Post
  • Go into fullscreen mode, either single or 'Side by Side'
  • Type some stuff
  • Save the document

When doing so I either get an error (remain in fullscreen) or no error (kicked out of fullscreen).

Other details:

Here is a screen capture showing the problem:

  • The first time I click the 'save' icon, I get the error, but remain fullscreen
  • The second time I click the 'save' icon, I get no error, and am kicked out of fullscreen.
@mertkahyaoglu
Copy link
Member

Thanks for reporting this. Might be related with #289 .

@mertkahyaoglu
Copy link
Member

There should be no error with the merge of #320 .

Exiting fullscreen on a successful save is an intended behavior since the state of the post/page changes, it refreshes the view which closes the fullscreen. Do you think it should stay open after saving?

@JohannesMP
Copy link
Contributor Author

JohannesMP commented Mar 16, 2017

Yes, I consider it switching view mode the equivalent of me choosing a custom layout in a program like Photoshop or Maya, and if I save it resets my Workspace layout. For many people manually saving is second nature, and pulling you out of the editor mode you chose to use deliberately is, in my opinion, disruptive to the experience.

@BlueWombat
Copy link
Contributor

I haven't tried to reproduce this, but I second your opinion of it being disruptive, and at the very least, not intuitive.

@jekyllbot
Copy link

This issue has been automatically marked as stale because it has not been commented on for at least two months.

The resources of the Jekyll team are limited, and so we are asking for your help.

If this is a bug and you can still reproduce this error on the master branch, please reply with all of the information you have about it in order to keep the issue open.

If this is a feature request, please consider whether it can be accomplished in another way. If it cannot, please elaborate on why it is core to this project and why you feel more than 80% of users would find this beneficial.

This issue will automatically be closed in two months if no further activity occurs. Thank you for all your contributions.

@JohannesMP
Copy link
Contributor Author

I still believe it would be better to not lose full screen state when saving in full screen.

However losing the ability to scroll (#433) is far more disruptive.

@jekyllbot jekyllbot removed the stale label Nov 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants