-
-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Post editor exiting fullscreen on save #305
Comments
Thanks for reporting this. Might be related with #289 . |
There should be no error with the merge of #320 . Exiting fullscreen on a successful save is an intended behavior since the state of the post/page changes, it refreshes the view which closes the fullscreen. Do you think it should stay open after saving? |
Yes, I consider it switching view mode the equivalent of me choosing a custom layout in a program like Photoshop or Maya, and if I save it resets my Workspace layout. For many people manually saving is second nature, and pulling you out of the editor mode you chose to use deliberately is, in my opinion, disruptive to the experience. |
I haven't tried to reproduce this, but I second your opinion of it being disruptive, and at the very least, not intuitive. |
This issue has been automatically marked as stale because it has not been commented on for at least two months. The resources of the Jekyll team are limited, and so we are asking for your help. If this is a bug and you can still reproduce this error on the If this is a feature request, please consider whether it can be accomplished in another way. If it cannot, please elaborate on why it is core to this project and why you feel more than 80% of users would find this beneficial. This issue will automatically be closed in two months if no further activity occurs. Thank you for all your contributions. |
I still believe it would be better to not lose full screen state when saving in full screen. However losing the ability to scroll (#433) is far more disruptive. |
Description:
When saving a post while in fullscreen mode (either single or double column view)
Could not update the doc
errorOddly enough, when I get the error the document does actually seem to have saved, as I can tell by reloading the 'live' version of the post.
So ironically, I actually prefer getting the error because then I don't get kicked out of fullscreen view.
Tell us a bit about yourself:
Steps to reproduce:
When doing so I either get an error (remain in fullscreen) or no error (kicked out of fullscreen).
Other details:
Here is a screen capture showing the problem:

The text was updated successfully, but these errors were encountered: