-
-
Notifications
You must be signed in to change notification settings - Fork 58
feat(lib): propagate manim render
exit code
#545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #545 +/- ##
=======================================
Coverage 80.09% 80.10%
=======================================
Files 23 23
Lines 2025 2026 +1
=======================================
+ Hits 1622 1623 +1
Misses 403 403 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
manim render
exit codemanim render
exit code
Thanks for your contribution @chrjabs! For this to be complete, could you:
Let me know if that is unclear :-) |
Thanks for the pointers. Feel free to squash when merging, or let me know what else is missing. Test output
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks for your contribution @chrjabs!
Fixes Issue
Closes #544
Description
Propagate the exit code of
manim render
when invokingmanim-slides render
.Check List
Check all the applicable boxes:
Screenshots
Note to reviewers