ci: remove caching from publishing workflows#630
Conversation
Removes all cache steps (nscloud-cache-action, Swatinem/rust-cache, actions/cache, sccache) from workflows that publish releases. The cache write/restore surface in privileged publishing paths is not worth the poisoning risk, even with branch protection at the cache backend. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
Greptile SummaryRemoves
Confidence Score: 5/5Safe to merge — the change removes a single read-only cache step from the publishing workflow without touching any build logic or credentials handling. A single cache step is deleted. The removed step used save-if: false so it never wrote anything; its only effect was warming build times. The remaining workflow is unchanged and the elevated secrets are not affected. No logic is altered, no side effects are introduced, and the other publishing workflow (publish-cli.yml) already had no cache steps. No files require special attention. Important Files Changed
Reviews (1): Last reviewed commit: "ci: remove caching from publishing workf..." | Re-trigger Greptile |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #630 +/- ##
=======================================
Coverage 78.94% 78.94%
=======================================
Files 49 49
Lines 7284 7284
Branches 7284 7284
=======================================
Hits 5750 5750
Misses 1147 1147
Partials 387 387 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary
nscloud-cache-action,Swatinem/rust-cache,actions/cache) from release / release-plz / publishing workflows.release-plz.yml, also removes the now-pointless sccache install/configure since it had no persistent backing store without the nscloud cache.Test plan
Note
Low Risk
Low risk: only adjusts GitHub Actions CI for publishing by removing the
Swatinem/rust-cachestep; main impact is slower cold builds but fewer cache-related supply-chain/permission concerns.Overview
The
release-plzGitHub Actions workflow no longer usesSwatinem/rust-cache, so the release/publish job runs without any Rust build caching.This reduces reliance on shared caches in a workflow that runs with write-level credentials, at the cost of potentially slower release builds.
Reviewed by Cursor Bugbot for commit a86d133. Bugbot is set up for automated code reviews on this repo. Configure here.