Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Used em units for their preferred reactivity #201

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

Dodge100
Copy link

Updated all pixel units em. This was as per issue #198.

Huge thanks to @benjamingwynn for his help with this as well.

Copy link

vercel bot commented Jun 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
98css ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 22, 2024 3:49am

@tazjin
Copy link

tazjin commented Jun 12, 2024

Cool!

FWIW, the preview that vercel generated above looks ... odd ... for me:

Screenshot 2024-06-12 at 16-55-38 98 css

This screenshot was taken in Firefox, but it looks the same way in Chromium.

@tazjin
Copy link

tazjin commented Jun 12, 2024

Actually the breakage in Chromium looks a little different:

98_chrome-1718200635

changed the 10.5 em to 1.5 em
this was for the radio thumb element
@Dodge100
Copy link
Author

all the bugs have been fixed! they were mostly just me typing 10 instead of 1. :P

@Dodge100
Copy link
Author

actually chromium looks weird 😞

@Dodge100
Copy link
Author

i found the issue. a lot of the elements are non-repsonsive.

@tazjin
Copy link

tazjin commented Jun 16, 2024

input[type="number"] still has an odd height in the last vercel deployment, otherwise everything seems to look more reasonable.

The default scale of stuff did change however, everything seems to be about 25% larger by default now, which leads to the pixelated fonts rendering blurry by default.

@Dodge100
Copy link
Author

the size being ~25% larger is due to no font size being set so it defaults to 16px. I am working on a patch to fix all of the elements using transformX/Y.

@ghost
Copy link

ghost commented Jul 21, 2024

Will this be merged?

@Dodge100
Copy link
Author

i've been a bit busy with irl stuff at the moment so haven't had much time to work on this. i do plan on working on it towards the start of august (no promises though).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants