Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

self() in parent is sufficient #17

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,6 @@ public Builder sauceInside() {
@Override public Calzone build() {
return new Calzone(this);
}

@Override protected Builder self() { return this; }
}

private Calzone(Builder builder) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ public Builder(Size size) {
return new NyPizza(this);
}

@Override protected Builder self() { return this; }
}

private NyPizza(Builder builder) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,13 @@ public T addTopping(Topping topping) {

abstract Pizza build();

// Subclasses must override this method to return "this"
protected abstract T self();
@SuppressWarnings("unchecked")
protected T self() {
// this is always of type T
// so there is no need to override
// self in subclasses
return (T) this;
}
}

Pizza(Builder<?> builder) {
Expand Down