fix PCI address in filepath for graphics cards #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure we take only the last PCI address in the `/sys/class/drm` sysfs output as the PCI Address of the graphics card. For some graphics cards, they are on a PCI bridge or host bus adapter that was erroneously being identified as the PCI Address of the graphics card itself. Consider this `ll /sys/class/drm` output on one of my workstations: ``` lrwxrwxrwx 1 root root 0 Mar 9 17:57 card0 -> ../../devices/pci0000:00/0000:00:02.0/drm/card0 lrwxrwxrwx 1 root root 0 Mar 9 17:57 card0-DP-1 -> ../../devices/pci0000:00/0000:00:02.0/drm/card0/card0-DP-1 lrwxrwxrwx 1 root root 0 Mar 9 17:57 card0-HDMI-A-1 -> ../../devices/pci0000:00/0000:00:02.0/drm/card0/card0-HDMI-A-1 lrwxrwxrwx 1 root root 0 Mar 9 17:57 card0-HDMI-A-2 -> ../../devices/pci0000:00/0000:00:02.0/drm/card0/card0-HDMI-A-2 lrwxrwxrwx 1 root root 0 Mar 9 17:57 card1 -> ../../devices/pci0000:00/0000:00:01.0/0000:01:00.0/drm/card1 lrwxrwxrwx 1 root root 0 Mar 9 17:57 card1-DP-2 -> ../../devices/pci0000:00/0000:00:01.0/0000:01:00.0/drm/card1/card1-DP-2 lrwxrwxrwx 1 root root 0 Mar 9 17:57 card1-DP-3 -> ../../devices/pci0000:00/0000:00:01.0/0000:01:00.0/drm/card1/card1-DP-3 lrwxrwxrwx 1 root root 0 Mar 9 17:57 card1-DP-4 -> ../../devices/pci0000:00/0000:00:01.0/0000:01:00.0/drm/card1/card1-DP-4 lrwxrwxrwx 1 root root 0 Mar 9 17:57 card1-HDMI-A-3 -> ../../devices/pci0000:00/0000:00:01.0/0000:01:00.0/drm/card1/card1-HDMI-A-3 lrwxrwxrwx 1 root root 0 Mar 9 17:57 renderD128 -> ../../devices/pci0000:00/0000:00:02.0/drm/renderD128 lrwxrwxrwx 1 root root 0 Mar 9 17:57 renderD129 -> ../../devices/pci0000:00/0000:00:01.0/0000:01:00.0/drm/renderD129 ``` Before this fix, `card1` was getting the PCI Address of `0000.:00:01.0` which was incorrect. After this fix, the PCI Address for `card` is the correct `000:01:00.0` which is the NVIDIA GPU itself not the Intel PCI bridge. Fixes Issue #407 Signed-off-by: Jay Pipes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure we take only the last PCI address in the
/sys/class/drmsysfs output as the PCI Address of the graphics card. For some graphics cards, they are on a PCI bridge or host bus adapter that was erroneously being identified as the PCI Address of the graphics card itself.Consider this
ll /sys/class/drmoutput on one of my workstations:Before this fix,
card1was getting the PCI Address of0000.:00:01.0which was incorrect. After this fix, the PCI Address forcardis the correct000:01:00.0which is the NVIDIA GPU itself not the Intel PCI bridge.Fixes Issue #407